On Sat, Apr 11, 2020 at 11:14:52AM -0400, Tom Lane wrote: > Noah Misch <n...@leadboat.com> writes: > > In summary, among those warnings, I see non-negative value in "Code before > > warnings are enabled" only. While we're changing this, I propose removing > > Subroutines::RequireFinalReturn. > > If it's possible to turn off just that warning, then +several.
We'd not get that warning if src/tools/perlcheck/pgperlcritic stopped enabling it by name, so it is possible to turn off by removing lines from that config. > It's routinely caused buildfarm failures, yet I can detect exactly > no value in it. If there were sufficient cross-procedural analysis > backing it to detect whether any caller examines the subroutine's > result value, then it'd be worth having. But there isn't, so those > extra returns are just pedantic verbosity. Agreed.
