Hi Michael so much the better!
-----Original Message----- From: Michael Paquier [mailto:[email protected]] Sent: Thursday, April 16, 2020 2:31 PM To: Zhang, Jie/张 杰 <[email protected]> Cc: [email protected] Subject: Re: [PATHC] Fix minor memory leak in pg_basebackup On Wed, Apr 15, 2020 at 10:06:52AM +0000, Zhang, Jie wrote: > In some cases , PGresult is not cleared. > > File: src\bin\pg_basebackup\streamutil.c > > bool > RetrieveWalSegSize(PGconn *conn) > { > PGresult *res; RetrieveWalSegSize() gets called only once at the beginning of pg_basebackup and pg_receivewal, so that's not an issue that has major effects, still that's an issue. The first one PQclear() is needed where you say. Now for the second one, I would just move it once the code is done with the query result, aka after calling PQgetvalue(). What do you think? Please see the attached. -- Michael
