On Wed, May 27, 2020 at 1:30 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > > There are more uses of BufFileRead that don't bother to distinguish > > these two cases apart, though -- logtape.c, tuplestore.c, > > gistbuildbuffers.c all do the same. > > Yeah. I rather suspect that callers of BufFileRead/Write are mostly > expecting that those functions will throw an ereport() for any interesting > error condition. Maybe we should make it so, instead of piecemeal fixing > the callers?
Yeah. I proposed that over here: https://www.postgresql.org/message-id/ca+hukgk0w+gts8advskdvu7cfzse5q+0np_9kpsxg2na1ne...@mail.gmail.com But I got stuck trying to figure out whether to back-patch (arguably yes: there are bugs here, but arguably no: the interfaces change).
