On Wed, Jun 10, 2020 at 5:02 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > On Wed, Jun 10, 2020 at 4:00 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > 2. Files should not be closed at the end of the transaction: > > > Currently, files opened with BufFileCreateShared/BufFileOpenShared are > > > registered to be closed on EOXACT. Basically, we need to open the > > > changes file on the stream start and keep it open until stream stop, > > > so we can not afford to get it closed on the EOXACT. I have added a > > > flag for the same. > > > > > > > But where do we end the transaction before the stream stop which can > > lead to closure of this file? > > Currently, I am keeping the transaction only while creating/opening > the files and closing immediately after that, maybe we can keep the > transaction until stream stop, then we can avoid this changes, and we > can also avoid creating extra resource owner? What is your thought on > this? >
I would prefer to keep the transaction until the stream stop unless there are good reasons for not doing so. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
