On Thu, Jun 18, 2020 at 8:23 PM Robert Haas <robertmh...@gmail.com> wrote: > > On Thu, Jun 18, 2020 at 5:55 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > For buffer replacement, many-a-times we have to also perform > > XLogFlush, what do we do for that? We can't proceed without doing > > that and erroring out from there means stopping read-only query from > > the user perspective. > > I think we should stop WAL writes, then XLogFlush() once, then declare > the system R/O. After that there might be more XLogFlush() calls but > there won't be any new WAL, so they won't do anything. > Yeah, the proposed v1 patch does the same.
Regards, Amul