On Mon, Jul 06, 2020 at 06:34:15AM +0200, Pavel Stehule wrote: > >> > Comment support is still missing but easily added :) > >> Still missing from the latest patch. > > > > I can implement a comment support. But I am not sure about the format. The > > here is support for comment's line - first char should be #
Thanks, that's how I assumed it would look. > >> With some added documentation, I think this can be RfC. Do you want to add any more documentation ? Few more things: > +exit_invalid_filter_format(FILE *fp, char *filename, char *message, char > *line, int lineno) > +{ > + pg_log_error("invalid format of filter file \"%s\": %s", > + *filename == '-' ? "stdin" : filename, > + message); You refer to as "stdin" any filename beginning with -. I think you could just print "-" and not "stdin". In any case, *filename=='-' is wrong since it only checks filename[0]. In a few places you compare ==stdin (which is right). Also, I think "f" isn't as good a name as "fp". You're adding 139 lines to a 600 line main(), and no other option is more than 15 lines. Would you put it in a separate function ? -- Justin