Hi hackers, PFA a patch that fixes up the identification for 4 header files.
I did a little archaeology trying to find plausible reasons for why we committed the wrong identification in the first place, and here's what I came up with: jsonfuncs.h was created in ce0425b162d0a to house backend-only json function declarations previously in jsonapi.h, and the identification was a copy-pasta from jsonapi.h (then in src/include/utils). jsonapi.h was wholesale moved to common in beb4699091e9f without changing identification. partdesc.h was created in 1bb5e78218107 but I can't find a good excuse why we made a mistake then, except for (maybe) the prototype for RelationBuildPartitionDesc() was moved from partcache.h and so we may have also taken its identification line, although that sounds arbitrary. llvmjit_emit.h was created with the wrong identification, probably due to a personal template... Cheers, Jesse
From 55c7280ee09ab258efc1c59b4ce6226228bcbab0 Mon Sep 17 00:00:00 2001 From: Jesse Zhang <sbje...@gmail.com> Date: Thu, 9 Jul 2020 13:39:39 -0700 Subject: [PATCH] Fix header identification. jsonfuncs.h was created in ce0425b162d0a to house backend-only json function declarations previously in jsonapi.h, and the identification was a copy-pasta from jsonapi.h (then in src/include/utils). jsonapi.h was wholesale moved to common in beb4699091e9f without changing identification. partdesc.h was created in 1bb5e78218107 but I can't find a good excuse why we made a mistake then, except for (maybe) the prototype for RelationBuildPartitionDesc() was moved from partcache.h and so we may have also taken its identification line, although that sounds arbitrary. llvmjit_emit.h was created with the wrong identification, probably due to a personal template... --- src/include/common/jsonapi.h | 2 +- src/include/jit/llvmjit_emit.h | 2 +- src/include/partitioning/partdesc.h | 2 +- src/include/utils/jsonfuncs.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/include/common/jsonapi.h b/src/include/common/jsonapi.h index bcfd57cc53c46..1fee0ea81e47a 100644 --- a/src/include/common/jsonapi.h +++ b/src/include/common/jsonapi.h @@ -6,7 +6,7 @@ * Portions Copyright (c) 1996-2020, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * src/include/utils/jsonapi.h + * src/include/common/jsonapi.h * *------------------------------------------------------------------------- */ diff --git a/src/include/jit/llvmjit_emit.h b/src/include/jit/llvmjit_emit.h index 74607a43770af..1a7d6db7259e0 100644 --- a/src/include/jit/llvmjit_emit.h +++ b/src/include/jit/llvmjit_emit.h @@ -4,7 +4,7 @@ * * Copyright (c) 2018-2020, PostgreSQL Global Development Group * - * src/include/lib/llvmjit_emit.h + * src/include/jit/llvmjit_emit.h */ #ifndef LLVMJIT_EMIT_H #define LLVMJIT_EMIT_H diff --git a/src/include/partitioning/partdesc.h b/src/include/partitioning/partdesc.h index fb416e073d075..70df764981e70 100644 --- a/src/include/partitioning/partdesc.h +++ b/src/include/partitioning/partdesc.h @@ -4,7 +4,7 @@ * * Copyright (c) 1996-2020, PostgreSQL Global Development Group * - * src/include/utils/partdesc.h + * src/include/partitioning/partdesc.h * *------------------------------------------------------------------------- */ diff --git a/src/include/utils/jsonfuncs.h b/src/include/utils/jsonfuncs.h index 1f1b4029cbf12..4796b2b78bf9a 100644 --- a/src/include/utils/jsonfuncs.h +++ b/src/include/utils/jsonfuncs.h @@ -6,7 +6,7 @@ * Portions Copyright (c) 1996-2020, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * src/include/utils/jsonapi.h + * src/include/utils/jsonfuncs.h * *------------------------------------------------------------------------- */ -- 2.27.0
