On Sat, Aug 1, 2020 at 4:46 AM Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Jun 26, 2020 at 8:36 AM Amit Langote <amitlangot...@gmail.com> wrote: > > 0001 and 0002 are preparatory patches. > > I read through these patches a bit but it's really unclear what the > point of them is. I think they need better commit messages, or better > comments, or both.
Thanks for taking a look. Sorry about the lack of good commentary, which I have tried to address in the attached updated version. I extracted one more part as preparatory from the earlier 0003 patch, so there are 4 patches now. Also as discussed with Daniel, I have changed the patches so that they can be applied on plain HEAD instead of having to first apply the patches at [1]. Without runtime pruning for UPDATE/DELETE proposed in [1], optimizing ResultRelInfo creation by itself does not improve the performance/scalability by that much, but the benefit of lazily creating ResultRelInfos seems clear so I think maybe it's okay to pursue this independently. -- Amit Langote EnterpriseDB: http://www.enterprisedb.com [1] https://www.postgresql.org/message-id/CA%2BHiwqHpHdqdDn48yCEhynnniahH78rwcrv1rEX65-fsZGBOLQ%40mail.gmail.com
v3-0003-Revise-child-to-root-tuple-conversion-map-managem.patch
Description: Binary data
v3-0004-Initialize-result-relation-information-lazily.patch
Description: Binary data
v3-0001-Revise-how-FDWs-obtain-result-relation-informatio.patch
Description: Binary data
v3-0002-Don-t-make-root-ResultRelInfo-for-insert-queries.patch
Description: Binary data