Hi Alexander, On Tue, Aug 4, 2020 at 7:27 AM Alexander Korotkov <aekorot...@gmail.com> wrote: > Thank you for your reminder. Revised patch is attached. Now, the contents > of deleted btree pages isn't masked. I've checked that installcheck passes > with wal_consistency_checking='Btree'. I'm going to push this if no > objections.
This looks good to me. One small thing, though: maybe the comments should not say anything about the REDO routine -- that seems like a case of "the tail wagging the dog" to me. Perhaps say something like: "Remove the last pivot tuple on the page. This keeps things simple for WAL consistency checking." (Just a suggestion.) Thanks! -- Peter Geoghegan