On Thu, 20 Aug 2020 at 22:29, Abhijit Menon-Sen <a...@toroid.org> wrote: > > At 2020-08-20 22:19:49 +1200, dgrowle...@gmail.com wrote: > > > > I was just looking over the JIT code and noticed a few comment and > > documentation typos. The attached fixes them. > > The first change does not seem to be correct: > > -That this is done at query execution time, possibly even only in cases > -where the relevant task is done a number of times, makes it JIT, > -rather than ahead-of-time (AOT). Given the way JIT compilation is used > -in PostgreSQL, the lines between interpretation, AOT and JIT are > -somewhat blurry. > +This is done at query execution time, possibly even only in cases where > +the relevant task is done a number of times, makes it JIT, rather than > +ahead-of-time (AOT). Given the way JIT compilation is used in PostgreSQL, > +the lines between interpretation, AOT and JIT are somewhat blurry. > > The original sentence may not be the most shining example of > sentence-ry, but it is correct, and removing the "That" breaks it.
Oh, I see. I missed that. Perhaps it would be better changed to "The fact that this" David