On Tue, Aug 25, 2020 at 12:59:31PM -0400, Tom Lane wrote: > Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > > Here is a series of patches to remove some unused function parameters. > > In each case, the need for them was removed by some other code changes > > over time but the unusedness was not noticed. I have included a > > reference to when they became unused in each case. > > For some of these, there's an argument for keeping the unused parameter > for consistency with sibling functions that do use it. Not sure how > important that is, though.
I think if they are kept for that reason, we should document that so we know not to revisit this issue for them. -- Bruce Momjian <br...@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee