On Tue, Sep 8, 2020 at 2:05 AM Juan José Santamaría Flecha <juanjo.santama...@gmail.com> wrote: > On Mon, Sep 7, 2020 at 1:41 PM Thomas Munro <thomas.mu...@gmail.com> wrote: >> Thanks for confirming. I ran the Windows patch through pgindent, >> fixed a small typo, and pushed. > > Great, thanks. Should we include something from this discussion as comments?
I dunno, it seems like this may be common knowledge for Windows people and I was just being paranoid by asking for more info as a non-Windowsian, but if you want to propose new comments or perhaps just a pointer to one central place where we explain how that works, I wouldn't be against that. FWIW I just spotted a couple of very suspicious looking failures for build farm animal "walleye", a "MinGW64 8.1.0" system, that say: c:\\pgbuildfarm\\pgbuildroot\\HEAD\\pgsql.build\\src\\bin\\pg_upgrade>RMDIR /s/q "c:\\pgbuildfarm\\pgbuildroot\\HEAD\\pgsql.build\\src\\bin\\pg_upgrade\\tmp_check\\data.old" The directory is not empty. Then I noticed it failed the same way 8 days ago, so I don't know what's up with that but it looks like we didn't break it...
