On Mon, Sep 7, 2020 at 2:29 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > > #2 > Originally when there was the FDW access in the transaction, > PREPARE TRANSACTION on that transaction failed with an error. The patch > allows PREPARE TRANSACTION and COMMIT/ROLLBACK PREPARED > even when FDW access occurs in the transaction. IMO this change can be > applied without *automatic* 2PC feature (i.e., PREPARE TRANSACTION and > COMMIT/ROLLBACK PREPARED are automatically executed for each FDW > inside "top" COMMIT command). Thought? > > I'm not sure yet whether automatic resolution of "unresolved" prepared > transactions by the resolver process is necessary for this change or not. > If it's not necessary, it's better to exclude the resolver process from this > change, at this stage, to make the patch simpler.
I agree with this. However, in case of explicit prepare, if we are not going to try automatic resolution, it might be better to provide a way to pass the information about transactions prepared on the foreign servers if they can not be resolved at the time of commit so that the user can take it up to resolve those him/herself. This was an idea that Tom had suggested at the very beginning of the first take. -- Best Wishes, Ashutosh Bapat
