On 2020-Sep-15, Tom Lane wrote: > I wrote: > > Alternatively, we might consider inventing an additional logging.c > > function pg_logging_increase_level() with the obvious semantics, and > > make the various programs just call that when they see a -v switch. > > That would be a slightly bigger patch, but it would more easily support > > programs with a range of useful verbosities, so maybe that's a better > > idea. > > After further thought, I concluded that's a clearly superior solution, > so 0001 attached does it like that. After noting that the enum values > are in the opposite direction from how I thought they went, I realized > that "increase_level" might be a bit ambiguous, so I now propose to > call it pg_logging_increase_verbosity.
I like this better too ... I've wished for extra-verbose messages from pg_dump in the past, and this now allows me to add something should I want them again. > > (Note: it seems possible that the theoretical multiple verbosity > > levels in pg_dump were already broken before cc8d41511, because > > right offhand I do not see any code that that removed that would > > have allowed invoking the higher levels either. > > Closer inspection says this was almost certainly true, because > I discovered that pg_dump -v -v crashes if you don't specify > an output filename :-(. So this has probably been unreachable > at least since we went over to using our own snprintf always; > before that, depending on platform, it might've been fine. > So we also need 0002 attached to fix that. Ugh. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
