On Sat, Sep 26, 2020 at 02:56:55PM -0500, Justin Pryzby wrote: > Also, if a partitioned index is clustered, when we clear indisclustered for > other indexes, should we also propogate that to their parent indexes, if any ?
I am not sure what you mean here. Each partition's cluster runs in its own individual transaction based on the patch you sent. Are you suggesting to update indisclustered for the partitioned index of a partitioned table and all its parent partitioned in the same transaction, aka a transaction working on the partitioned table? Doesn't that mean that if we have a partition tree with multiple layers then we finish by doing multiple time the same operation for the parents? >> It would be good also to check if >> we have a partition index tree that maps partially with a partition >> table tree (aka no all table partitions have a partition index), where >> these don't get clustered because there is no index to work on. > > This should not happen, since a incomplete partitioned index is "invalid". Indeed, I did not know this property. I can see also that you have added a test for this case, so that's good if we can rely on that. I am still in the process of reviewing this patch, all this handling around indisclustered makes it rather complex. -- Michael
signature.asc
Description: PGP signature
