On Thu, Oct 8, 2020 at 12:12 PM Hou, Zhijie <houzj.f...@cn.fujitsu.com>
wrote:
> Hi
>
> I have a look over this patch and find some typos in 0002.
>
> 1.Some typos about unique:
> There are some spelling mistakes about "unique" in code comments and
> README.
> Such as: "+However we define the UnqiueKey as below."
>
> 2.function name about initililze_uniquecontext_for_joinrel:
> May be it should be initialize_ uniquecontext_for_joinrel.
>
> 3.some typos in comment:
> + * baserelation's basicrestrictinfo. so it must be
> in ON clauses.
>
> I think it shoule be " basicrestrictinfo " => "baserestrictinfo".
>
>
> Besides, I think list_copy can be used to simplify the following code.
> (But It seems the type of expr is still in discussion, so this may has no
> impact )
> + List *exprs = NIL;
> ...
> + foreach(lc, unionrel->reltarget->exprs)
> + {
> + exprs = lappend(exprs, lfirst(lc));
> + }
>
> Best regards,
>
>
>
Thank you zhijie, I will fix them in next version.
--
Best Regards
Andy Fan
