On Tue, Oct 27, 2020 at 8:51 AM Justin Pryzby <pry...@telsasoft.com> wrote: > > On Fri, Oct 23, 2020 at 10:45:34AM +0530, Amit Kapila wrote: > > On Fri, Oct 23, 2020 at 8:59 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > While updating the streaming stats patch, it occurred to me that we > > can write a better description spill_bytes as well. Attached contains > > the update to spill_bytes description. > > + This and other spill > + counters can be used to gauge the I/O occurred during logical > decoding > + and accordingly can tune > <literal>logical_decoding_work_mem</literal>. > > "gauge the IO occurred" is wrong. > Either: I/O *which* occured, or I/O occurring, or occurs. > > "can tune" should say "allow tuning". > > Like: > + This and other spill > + counters can be used to gauge the I/O which occurs during logical > decoding > + and accordingly allow tuning of > <literal>logical_decoding_work_mem</literal>. > > - Number of times transactions were spilled to disk. Transactions > + Number of times transactions were spilled to disk while performing > + decoding of changes from WAL for this slot. Transactions > > What about: "..while decoding changes.." (remove "performing" and "of"). >
All of your suggestions sound good to me. Find the patch attached to update the docs accordingly. -- With Regards, Amit Kapila.
0001-Minor-improvements-in-description-of-spilled-counter.patch
Description: Binary data
