On Mon, Nov 2, 2020 at 10:28 PM Julien Rouhaud <rjuju...@gmail.com> wrote: > + /* Remember not to complain about this collation again. */ > + context->checked_colls = lappend_oid(context->checked_colls, > + otherObject->objectId); > > It's maybe not immediately obvious that it's safe to save the > collation oid at that point, or that it'll always be. Maybe move it > in the if branch above to make it extra clear?
Ok, moved and renamed, and finally pushed. Thanks for all the help!
