> 5 нояб. 2020 г., в 22:20, Justin Pryzby <pry...@telsasoft.com> написал(а): > > On Thu, Nov 05, 2020 at 10:11:52PM +0500, Andrey Borodin wrote: >> To test that functions are actually called for sorting build we should >> support directive sorting build like "CREATE INDEX ON A USING GIST(B) >> WITH(sorting=surely,and fail if not)". > > Maybe you could add a DEBUG1 message for that, and include that in regression > tests, which would then fail if sorting wasn't used.
That's a good idea. Thanks! > > Maybe you'd need to make it consistent by setting GUCs like work_mem / > max_parallel_maintenance_workers / ?? > > Similar to this > > postgres=# SET client_min_messages =debug; > postgres=# CREATE INDEX ON A USING GIST(i) WITH(buffering=off); > DEBUG: building index "a_i_idx2" on table "a" serially > CREATE INDEX Currently, only B-tree uses parallel build, so no need to tweak GUCs except client_min_messages. Before these tests, actually, ~20% of opclasses were not working as expected. Despite I've checked each one by hand. I have PFA patch with fixed comments from Heikki. Thanks! Best regards, Andrey Borodin.
v4-0001-Sortsupport-for-sorting-GiST-build-for-gist_btree.patch
Description: Binary data
