On Wed, Nov 25, 2020 at 12:50 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > On 2020-Nov-24, Tom Lane wrote: > > > Robert Haas <robertmh...@gmail.com> writes: > > > > Oh, I thought it had been suggested in previous discussions that these > > > should be treated as access methods rather than inventing a whole new > > > concept just for this, and it seemed like a good idea to me. I guess I > > > missed the fact that the patch wasn't doing it that way. Hmm. > > > > FWIW, I kind of agree with Robert's take on this. Heap and index AMs > > are pretty fundamentally different animals, yet we don't have a problem > > sticking them in the same catalog. I think anything that is related to > > storage access could reasonably go into that catalog, rather than > > inventing a new one. > > Right -- Something like amname=lz4, amhandler=lz4handler, amtype=c. > The core code must of course know how to instantiate an AM of type > 'c' and what to use it for. > > https://postgr.es/m/20171213151818.75a20...@postgrespro.ru
I have changed this, I agree that using the access method for creating compression has simplified the code. I will share the updated patch set after fixing other review comments by Robert. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
