чт, 31 дек. 2020 г. в 20:01, Zhihong Yu <z...@yugabyte.com>: > For v12-0001-Pass-down-logically-unchanged-index-hint.patch > > + if (hasexpression) > + return false; > + > + return true; > > The above can be written as return !hasexpression; >
To be honest, I prefer the way Peter has it in his patch. Yes, it's possible to shorten this part. But readability is hurt — for current code I just read it, for the suggested change I need to think about it. -- Victor Yegorov