On Mon, Jan 4, 2021 at 8:06 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > Few other comments: > ================= > 1. > + elog(LOG, "!!>> DropSubscription: dropping the tablesync slot > \"%s\".", syncslotname); > + ReplicationSlotDropAtPubNode(wrconn, syncslotname); > + elog(LOG, "!!>> DropSubscription: dropped the tablesync slot > \"%s\".", syncslotname); > > ... > ... > > + elog(LOG, "!!>> finish_sync_worker: dropping the tablesync slot > \"%s\".", syncslotname); > + ReplicationSlotDropAtPubNode(wrconn, syncslotname); > + elog(LOG, "!!>> finish_sync_worker: dropped the tablesync slot > \"%s\".", syncslotname); > > Remove these and other elogs added to aid debugging or testing. If you > need these for development purposes then move these to separate patch.
Fixed in latest patch (v10). > > 2. Remove WIP from the commit message and patch name. > > -- Fixed in latest patch (v10) --- v10 = https://www.postgresql.org/message-id/CAHut%2BPuzPmFzk3p4oL9H3nkiY6utFryV9c5dW6kRhCe_RY%3DgnA%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia