On Sun, Jan 3, 2021 at 8:58 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Mon, Jan 4, 2021 at 12:55 PM Peter Geoghegan <p...@bowt.ie> wrote: > +1 for changing heapdesc.c on master. It's not only readable but also > consistent with other *desc showing the field named latestRemovedXid. > For instance, nbtdesc.c has: > > case XLOG_BTREE_REUSE_PAGE: > { > xl_btree_reuse_page *xlrec = (xl_btree_reuse_page *) rec; > > appendStringInfo(buf, "rel %u/%u/%u; latestRemovedXid %u", > xlrec->node.spcNode, xlrec->node.dbNode, > xlrec->node.relNode, > xlrec->latestRemovedXid); > break; > }
Right. Self-consistency matters, as does consistency with the source code itself. -- Peter Geoghegan