On Wed, Jan 6, 2021 at 10:05 AM Zhihong Yu <z...@yugabyte.com> wrote: > > The plan sounds good. > > Before the second command type is added, can you leave out the 'if (ins_cmd > == PARALLEL_INSERT_CMD_CREATE_TABLE_AS)' and keep the pair of curlies ? > > You can add the if condition back when the second command type is added.
Thanks. IMO, an empty pair of curlies is not a good idea. Having if (ins_cmd == PARALLEL_INSERT_CMD_CREATE_TABLE_AS) doesn't harm anything. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com