Hi Vignesh, I had a look at the patch, please consider following comments.
On Thu, Jan 7, 2021 at 10:03 PM vignesh C <vignes...@gmail.com> wrote: > Hi, > > This feature adds schema option while creating publication. Users will > be able to specify one or more schemas while creating publication, > when the user specifies schema option, then the data changes for the > tables present in the schema specified by the user will be replicated > to the subscriber. Few examples have been listed below: > > Create a publication that publishes all changes for all the tables > present in production schema: > CREATE PUBLICATION production_publication FOR ALL TABLES SCHEMA production; > > Should it be FOR TABLES IN SCHEMA instead of FOR ALL TABLES SCHEMA? > Create a publication that publishes all changes for all the tables > present in marketing and sales schemas: > CREATE PUBLICATION sales_publication FOR ALL TABLES SCHEMA marketing, > sales; > > Add some schemas to the publication: > ALTER PUBLICATION sales_publication ADD SCHEMA marketing_june, sales_june; > > As per current implementation this command fails even if one of the schemas does not exist. I think this is counterintuitive, it should throw a warning and continue adding the rest. > Drop some schema from the publication: > ALTER PUBLICATION production_quarterly_publication DROP SCHEMA > production_july; > > Same for drop schema, if one of these schemas does not exist in publication, the entire DROP operation is aborted. Thank you, Rahila Syed
