On Tue, Jan 12, 2021 at 3:18 PM Ajin Cherian <itsa...@gmail.com> wrote: > > On Wed, Jan 6, 2021 at 11:56 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > Now, let us see how the tests mentioned by me cover this code. In the > > first test (check that 2PC gets replicated to subscriber then ROLLBACK > > PREPARED), we do below on publisher and wait for it to be applied on > > the subscriber. > > BEGIN; > > INSERT INTO tab_full VALUES (12); > > PREPARE TRANSACTION 'test_prepared_tab_full'; > > ROLLBACK PREPARED 'test_prepared_tab_full'; > .. > > Also restarted server2 and confirmed that the rollback prepared was > not re-sent again. >
Thanks for doing these tests. I think you can put an elog in the below code change as well to show that the recovery code path is also hit: +xact_redo_abort(xl_xact_parsed_abort *parsed, TransactionId xid, + XLogRecPtr lsn, RepOriginId origin_id) { ... + if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN) + { + /* recover apply progress */ + replorigin_advance(origin_id, parsed->origin_lsn, lsn, + false /* backward */, false /* WAL */); + } -- With Regards, Amit Kapila.