On Mon, Jan 25, 2021 at 1:58 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Sun, Jan 24, 2021 at 12:24 PM Peter Smith <smithpb2...@gmail.com> wrote: > > > > On Sat, Jan 23, 2021 at 11:26 PM Amit Kapila <amit.kapil...@gmail.com> > > wrote: > > > > > > > > > Few comments: > > > ============= > > > 1. > > > - * So the state progression is always: INIT -> DATASYNC -> SYNCWAIT -> > > > - * CATCHUP -> SYNCDONE -> READY. > > > + * So the state progression is always: INIT -> DATASYNC -> > > > + * (sync worker FINISHEDCOPY) -> SYNCWAIT -> CATCHUP -> SYNCDONE -> > > > READY. > > > > > > I don't think we need to be specific here that sync worker sets > > > FINISHEDCOPY state. > > > > > > > This was meant to indicate that *only* the sync worker knows about the > > FINISHEDCOPY state, whereas all the other states are either known > > (assigned and/or used) by *both* kinds of workers. But, I can remove > > it if you feel that distinction is not useful. > > > > Okay, but I feel you can mention that in the description you have > added for FINISHEDCOPY state. It looks a bit odd here and the message > you want to convey is also not that clear. >
The comment is updated in the latest patch [v20]. ---- [v20] https://www.postgresql.org/message-id/CAHut%2BPuNwSujoL_dwa%3DTtozJ_vF%3DCnJxjgQTCmNBkazd8J1m-A%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
