On 2021-Jan-26, Tom Lane wrote: > Alvaro Herrera <alvhe...@alvh.no-ip.org> writes: > > pgbench has one occurrence of the old pattern in master, in line 6043. > > However, since doConnect() returns NULL when it gets CONNECTION_BAD, > > that seems dead code. This patch kills it. > > Oh ... I missed that because it wasn't adjacent to the PQconnectdbParams > call :-(. You're right, that's dead code and we should just delete it.
Pushed, thanks. -- Álvaro Herrera 39°49'30"S 73°17'W "Pensar que el espectro que vemos es ilusorio no lo despoja de espanto, sólo le suma el nuevo terror de la locura" (Perelandra, C.S.Lewis)
