On Tue, Feb 9, 2021 at 3:37 PM Justin Pryzby <pry...@telsasoft.com> wrote: > I think you misunderstood: I mean that the WIP patch should default to > --enable-lz4, to exercise on a few CI. It's hardly useful to run CI with the > feature disabled. I assume that the patch would be committed with default > --disable-lz4.
Oh, I see. I guess we could do that. > Right, it's not one-time, it's also whenever setting a non-default compression > method. I say it should go into 0001 to avoid a whole bunch of churn in > src/test/regress, and then more churn (and rebase conflicts in other patches) > while adding HIDE_COMPRESSAM in 0002. Hmm, I guess that makes some sense, too. I'm not sure either one is completely critical, but it does make sense to me now. -- Robert Haas EDB: http://www.enterprisedb.com
