On 10 Feb 2021, at 06:32, Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Feb 10, 2021 at 7:41 AM Peter Smith <smithpb2...@gmail.com> wrote: >> >> On Tue, Feb 9, 2021 at 10:38 AM Peter Smith <smithpb2...@gmail.com> wrote: >>> >> >> PSA v2 of this WalRcvExceResult patch (it is same as v1 but includes >> some PG doc updates). >> This applies OK on top of v30 of the main patch. >> > > Thanks, I have integrated these changes into the main patch and > additionally made some changes to comments and docs. I have also fixed > the function name inconsistency issue you reported and ran pgindent.
One thing: > + else if (res->status == WALRCV_ERROR && > + missing_ok && > + res->sqlstate == ERRCODE_UNDEFINED_OBJECT) > + { > + /* WARNING. Error, but missing_ok = true. */ > + ereport(WARNING, > (errmsg("could not drop the replication > slot \"%s\" on publisher", > slotname), > errdetail("The error was: %s", > res->err))); Hmm, why is this WARNING, we mostly call it with missing_ok = true when the slot is not expected to be there, so it does not seem correct to report it as warning? -- Petr