On Fri, Feb 12, 2021 at 12:29 PM osumi.takami...@fujitsu.com <osumi.takami...@fujitsu.com> wrote: > > On Thursday, February 11, 2021 5:10 PM Peter Smith <smithpb2...@gmail.com> > wrote: > > Please find attached the new 2PC patch set v39* > I started to review the patchset > so, let me give some comments I have at this moment. > > (1) > > File : v39-0007-Support-2PC-txn-tests-for-concurrent-aborts.patch > Modification : > > @@ -620,6 +666,9 @@ pg_decode_change(LogicalDecodingContext *ctx, > ReorderBufferTXN *txn, > } > txndata->xact_wrote_changes = true; > > + /* For testing concurrent aborts */ > + test_concurrent_aborts(data); > + > class_form = RelationGetForm(relation); > tupdesc = RelationGetDescr(relation); > > Comment : There are unnecessary whitespaces in comments like above in v37-007 > Please check such as pg_decode_change(), pg_decode_truncate(), > pg_decode_stream_truncate() as well. > I suggest you align the code formats by pgindent. >
This patch (v39-0007-Support-2PC-txn-tests-for-concurrent-aborts.patch) is mostly for dev-testing purpose. We don't intend to commit as this has a lot of timing-dependent tests and I am not sure if it is valuable enough at this stage. So, we can ignore cosmetic comments in this patch for now. -- With Regards, Amit Kapila.
