On Sat, Feb 13, 2021 at 11:41 AM japin <japi...@hotmail.com> wrote: > > IIUC, with the current patch, the new ALTER SUBSCRIPTION ... ADD/DROP > > errors out on the first publication that already exists/that doesn't > > exist right? What if there are multiple publications given in the > > ADD/DROP list, and few of them exist/don't exist. Isn't it good if we > > loop over the subscription's publication list and show all the already > > existing/not existing publications in the error message, instead of > > just erroring out for the first existing/not existing publication? > > > > Yes, you are right. Agree with you, I modified it. Please consider v5 > for further review.
Thanks for the updated patches. I have a comment about reporting the existing/not existing publications code. How about something like the attached delta patch on v5-0002? Sorry for attaching I also think that we could merge 0002 into 0001 and have only 4 patches in the patch set. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
v1-0001-delta-patch-for-reporting-error.patch
Description: Binary data
