From: Zhihong Yu <z...@yugabyte.com> 
> This feature enables bulk COPY into foreign table in the case of
> multi inserts is possible
> 
> 'is possible' -> 'if possible'
> 
> FDWAPI was extended by next routines:
> 
> next routines -> the following routines

Thank you, fixed slightly differently.  (I feel the need for pgEnglish again.)


> +       if ((!OK && PQresultStatus(res) != PGRES_FATAL_ERROR) ||
> 
> Is PGRES_FATAL_ERROR handled somewhere else ? I don't seem to find that in 
> the patch.

Good catch.  ok doesn't need to be consulted here, because failure during row 
transmission causes PQputCopyEnd() to receive non-NULL for its second argument, 
which in turn makes PQgetResult() return non-COMMAND_OK.


Regards
Takayuki Tsunakawa

Attachment: v18-0001-Fast-COPY-FROM-into-the-foreign-or-sharded-table.patch
Description: v18-0001-Fast-COPY-FROM-into-the-foreign-or-sharded-table.patch

Reply via email to