On Sat, Mar 6, 2021 at 9:19 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Fri, Mar 5, 2021 at 6:34 PM Greg Nancarrow <gregn4...@gmail.com> wrote: > > > > For the time being at least, I am posting an updated set of patches, > > as I found that the additional parallel-safety checks on DOMAIN check > > constraints to be somewhat inefficient and could also be better > > integrated into max_parallel_hazard(). I also updated the basic tests > > with a test case for this. > > > > Thanks, your changes look good to me. I went ahead and changed the > patch to track the partitionOids once rather than in two separate > lists and use that list in PlanCacheRelCallback to invalidate the > plans. I made few other changes: > a. don't need to retain the lock on indexes as we can't change index > expressions > b. added/updated comments at few places in the code. > c. made a few other cosmetic changes > d. ran pgindent > e. slightly modify the commit message. > f. combine the code and test case patch > > For now, I have left 0005 and 0006 patches, we can come back to those > once we are done with the first set of patches. The first patch looks > good to me and I think we can commit it and then bikeshed about > GUC/reloption patch. >
I've checked and tested the changes, and the resultant patches look OK to me, so I'm happy for you to commit the first patch. Regards, Greg Nancarrow Fujitsu Australia
