Hi,
Two minor nits:
On 2021-03-10 21:47:51 +0900, Fujii Masao wrote:
> +/* Shared memory area for archiver process */
> +typedef struct PgArchData
> +{
> + Latch *latch; /* latch to wake the archiver
> up */
> + slock_t mutex; /* locks this struct */
> +} PgArchData;
> +
It doesn't really matter, but it'd be pretty trivial to avoid needing a
spinlock for this kind of thing. Just store the pgprocno of the archiver
in PgArchData.
While getting rid of the spinlock doesn't seem like a huge win, it does
seem nicer that we'd automatically have a way to find data about the
archiver (e.g. pid).
> * checkpointer to exit as well, otherwise not. The archiver,
> stats,
> * and syslogger processes are disregarded since they are not
> * connected to shared memory; we also disregard dead_end
> children
> * here. Walsenders are also disregarded, they will be
> terminated
> * later after writing the checkpoint record, like the archiver
> * process.
> */
This comment in PostmasterStateMachine() is outdated now.
Greetings,
Andres Freund
