On Fri, Mar 12, 2021 at 11:24:57AM +0530, Dilip Kumar wrote: > On Fri, Mar 12, 2021 at 10:45 AM Justin Pryzby <pry...@telsasoft.com> wrote: > > > > On Thu, Mar 11, 2021 at 12:25:26PM -0600, Justin Pryzby wrote: > > > On Wed, Mar 10, 2021 at 08:28:58PM -0600, Justin Pryzby wrote: > > > > This includes a patch to use pkgconfig, in an attempt to build on mac, > > > > which > > > > currently fails like: > > > > > > > > https://cirrus-ci.com/task/5993712963551232?command=build#L126 > > > > checking for LZ4_compress in -llz4... no > > > > configure: error: library 'lz4' is required for LZ4 support > > > > > > This includes a 2nd attempt to use pkg-config to build on mac. > > > > > > If this doesn't work, we should ask for help from a mac user who wants to > > > take > > > on a hopefully-quick project. > > > > The 2nd attempt passed ./configure on mac (and BSD after Thomas installed > > pkg-config), but I eventually realized that LZ4 was effectively disabled, > > because we set HAVE_LZ4, but the code tested instead WITH_LIBLZ4. > > So is it working on the Mac with your latest changes in 0005 or we > need to wait for the result? Also is there any reason for changing > HAVE_LIBLZ4 to USE_LZ4?
It worked everywhere (but everytime someone mail this thread, it queues a rebuild). http://cfbot.cputube.org/dilip-kumar.html HAVE_LIBLZ4 was being set by AC_CHECK_LIB(), which is no longer used in favour of pkgconfig. https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Libraries.html I saw that PGAC_ARG_BOOL() is setting other USE variables but not HAVE vars, so I used USE_LZ4 and changed the code for consistency. -- Justin
