On Tue, Mar 23, 2021 at 9:01 PM Peter Smith <smithpb2...@gmail.com> wrote: > > On Tue, Mar 23, 2021 at 10:44 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > On Mon, Mar 22, 2021 at 11:51 PM Amit Kapila <amit.kapil...@gmail.com> > > wrote: > > > > > > I have incorporated all your changes and additionally made few more > > > changes (a) got rid of LogicalRepBeginPrepareData and instead used > > > LogicalRepPreparedTxnData, (b) made a number of changes in comments > > > and docs, (c) ran pgindent, (d) modified tests to use standard > > > wait_for_catch function and removed few tests to reduce the time and > > > to keep regression tests reliable. > > > > I checked all v65* / v66* differences and found only two trivial comment > > typos. > > > > PSA patches to fix those. > > > > Hi Amit. > > PSA a patch to allow the ALTER SUBSCRIPTION ... REFRESH PUBLICATION to > work when two-phase tristate is PENDING. > > This is necessary for the pg_dump/pg_restore scenario, or for any > other use-case where the subscription might > start off having no tables. > > Please apply this on top of your v66-0001 (after applying the other > Feedback patches I posted earlier today). >
PSA a small addition to the 66-0003 "Fix to allow REFRESH PUBLICATION" patch posted yesterday. This just updates the worker.c comment. ------ Kind Regards, Peter Smith. Fujitsu Australia.
v66-0004-Updated-worker.c-comment.patch
Description: Binary data