On Mon, Mar 29, 2021 at 4:22 PM Markus Wanner <markus.wan...@enterprisedb.com> wrote: > > On 29.03.21 12:18, vignesh C wrote: > > But in prepare_filter_cb callback, by stating "other systems ..." it is > > not very clear who will change the GID. Are we referring to > > publisher/subscriber decoding? > > Thanks for your feedback. This is not about GIDs at all, but just about > identifying a transaction. I'm out of ideas on how else to phrase that. > Any suggestion? > > Maybe we should not try to give examples and reference other systems, > but just leave it at: > > The <parameter>ctx</parameter> parameter has the same contents as for > the other callbacks. The parameters <parameter>xid</parameter> > and <parameter>gid</parameter> provide two different ways to identify > the transaction. The later <command>COMMIT PREPARED</command> or > <command>ROLLBACK PREPARED</command> carries both identifiers, > providing an output plugin the choice of what to use. > > That is sufficient an explanation in my opinion. What do you think?
The above content looks sufficient to me. As we already explain this earlier "The optional filter_prepare_cb callback is called to determine whether data that is part of the current two-phase commit transaction should be considered for decoding at this prepare stage or later as a regular one-phase transaction at COMMIT PREPARED time." which helps in understanding what filter_prepare_cb means. Thoughts? Regards, Vignesh