On Tue, Apr 6, 2021 at 6:49 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > On Tue, Apr 6, 2021 at 3:08 PM Amit Langote <amitlangot...@gmail.com> wrote: > > Updated patch attached. I had to adjust the test case a little bit to > > account for the changes of 86dc90056d, something I failed to notice > > yesterday. Also, I expanded the test case added in postgres_fdw.sql a > > bit to show the batching in action more explicitly. > > Some minor comments:
Thanks for the review. > 1) don't we need order by clause for the selects in the tests added? > +SELECT tableoid::regclass, * FROM batch_cp_upd_test; Good point. It wasn't necessary before, but it is after the test expansion, so added. > 3) will the cmin in the output always be the same? > +SELECT cmin, * FROM batch_cp_upd_test3; TBH, I am not so sure. Maybe it's not a good idea to rely on cmin after all. I've rewritten the tests to use a different method of determining if a single or multiple insert commands were used in moving rows into foreign partitions. -- Amit Langote EDB: http://www.enterprisedb.com
v5-0001-Allow-batching-of-inserts-during-cross-partition-.patch
Description: Binary data
