I've attached v15. > I still feel that the above bunch of code is duplicate of what > do_sql_command function already has. I would recommend that we just > make that function non-static(it's easy to do) and keep the > declaration in postgres_fdw.h and use it in the > postgresExecForeignTruncate.
I've tried this on v15. > Another minor comment: > We could move + ForeignServer *serv = NULL; within foreach (lc, > frels_list), because it's not being used outside. I've moved it. > cfbot failure on v14 - https://cirrus-ci.com/task/4772360931770368. > Looks like it is not related to this patch, please re-confirm it. I've checked v15 patch with "make check-world" and confirmed this passed. 2021年4月6日(火) 23:25 Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com>: > > On Tue, Apr 6, 2021 at 5:36 PM Kazutaka Onishi <oni...@heterodb.com> wrote: > > > > Thank you for checking v13, and here is v14 patch. > > cfbot failure on v14 - https://cirrus-ci.com/task/4772360931770368. > Looks like it is not related to this patch, please re-confirm it. > > With Regards, > Bharath Rupireddy. > EnterpriseDB: http://www.enterprisedb.com
pgsql14-truncate-on-foreign-table.v15.patch
Description: Binary data
