On Thu, Apr 8, 2021 at 1:34 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > Amit Langote <amitlangot...@gmail.com> writes: > > Also, I think we should update the commentary around ri_projectNew a > > bit to make it clear that noplace beside ExecGet{Insert|Update}Tuple > > should be touching it and the associated slots. > > Hm. I pushed your comment fixes in nodeModifyTable.c, but not this > change, because it seemed to be more verbose and not really an > improvement. Why are these fields any more hands-off than any others? > Besides which, there certainly is other code touching ri_oldTupleSlot.
Oops, that's right. > Anyway, I've marked the CF entry closed, because I think this is about > as far as we can get for v14. I'm not averse to revisiting the > RETURNING and WITH CHECK OPTIONS issues later, but it looks to me like > that needs more study. Sure, I will look into that. -- Amit Langote EDB: http://www.enterprisedb.com