On 4/17/21 9:04 AM, Michael Paquier wrote: > On Thu, Apr 15, 2021 at 09:12:52PM -0400, Andrew Dunstan wrote: >> It's worked on fairywren, I will double check on drongo and if all is >> well will commit. > Thanks Andrew. For the archive's sake, this has been committed as of > 3c5b068. > > While reading the commit, I have noticed that you used SEEK_SET > instead of 0 as I did in my own patch. That makes the code easier to > understand. Could it be better to apply the same style to all the > perl scripts doing some seek() calls? Please see the attached.
Yes please, much better to use a symbolic name rather than a magic number. I wouldn't bother backpatching it though. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com