Yura Sokolov писал 2021-04-18 23:29:
Tom Lane писал 2021-04-13 17:45:
Justin Pryzby <pry...@telsasoft.com> writes:
On Fri, Apr 09, 2021 at 04:28:25PM +0300, Yura Sokolov wrote:
Occasinally I found I'm not able to `make check` old Postgresql
versions.
I've bisected between REL_11_0 and "Rename pg_rewind's
copy_file_range()"
and
found 372728b0d49552641f0ea83d9d2e08817de038fa
Replace our traditional initial-catalog-data format with a better
design.
This is first commit where `make check` doesn't fail during initdb
on my
machine.
This doesn't make much sense or help much, since 372728b doesn't
actually
change the catalogs, or any .c file.
It could make sense if some part of the toolchain that was previously
used to generate postgres.bki doesn't work right on that machine.
Overall though I'd have thought that 372728b would increase not
decrease our toolchain footprint. It also seems unlikely that a
recent Ubuntu release would contain toolchain bugs that we hadn't
already heard about.
You used make clean too, right ?
Really, when bisecting, you need to use "make distclean" or even
"git clean -dfx" between steps, or you may get bogus results,
because our makefiles aren't that great about tracking dependencies,
especially when you move backwards in the history.
Yep, "git clean -dfx" did the job. "make distclean" didn't, btw.
I've had "src/backend/catalog/schemapg.h" file in source tree
generated with "make submake-generated-headers" on REL_13_0.
It were not shown with "git status", therefore I didn't notice its
existence. It were not deleted neither with "make distclean", nor with
"git clean -dx" I tried before. Only "git clean -dfx" deletes it.
Thank you for the suggestion, Tom. You've saved my sanity.
Regards,
Yura Sokolov.
