On Tue, Apr 20, 2021 at 01:11:59PM -0400, Andrew Dunstan wrote: > Here's the patch for that.
Thanks.
> + # Accept standard formats, in case caller has handed us the output of a
> + # postgres command line tool
> + $arg = $1
> + if ($arg =~ m/\(?PostgreSQL\)? (\d+(?:\.\d+)*(?:devel)?)/);
Interesting. This would work even if using --with-extra-version,
which is a good thing.
> +# render the version number in the standard "joined by dots" notation if
> +# interpolated into a string
> +sub _stringify
> +{
> + my $self = shift;
> + return join('.', @$self);
> +}
This comes out a bit strangely when using a devel build as this
appends -1 as sub-version number, becoming say 14.-1. It may be
clearer to add back "devel" in this case?
Wouldn't it be better to add some perldoc to PostgresVersion.pm?
--
Michael
signature.asc
Description: PGP signature
