On Thu, Apr 22, 2021 at 1:02 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: >
Thanks, it looks good to me now. I'll review/test some more before committing but at this stage, I would like to know from Andres or others whether they see any problem with this approach to fixing a few of the problems reported in this thread. Basically, it will fix the cases where the drop message is lost and we were not able to record stats for new slots and writing beyond the end of the array when after restarting the number of slots whose stats are stored in the stats file exceeds max_replication_slots. It uses HTAB instead of an array to record slot stats and also taught pgstat_vacuum_stat() to search for all the dead replication slots in stats hashtable and tell the collector to remove them. This still uses slot_name as the key because we were not able to find a better way to use slot's idx. Andres, unless you see any problems with this approach, I would like to move forward with this early next week? -- With Regards, Amit Kapila.
