Would anyone oppose me pushing this for tab-completing the new keywords
of
ALTER TABLE ..  DETACH PARTITION?

-- 
Álvaro Herrera       Valdivia, Chile
"Por suerte hoy explotó el califont porque si no me habría muerto
 de aburrido"  (Papelucho)
>From 4ab605c1e1ed87ef92370bc6205a8b786739f774 Mon Sep 17 00:00:00 2001
From: Alvaro Herrera <alvhe...@alvh.no-ip.org>
Date: Thu, 22 Apr 2021 16:37:46 -0400
Subject: [PATCH] tab-complete ALTER TABLE DETACH PARTITION with
 CONCURRENTLY/FINALIZE

---
 src/bin/psql/tab-complete.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index ed84b3789c..7c4933333b 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -2209,6 +2209,8 @@ psql_completion(const char *text, int start, int end)
 		completion_info_charp = prev3_wd;
 		COMPLETE_WITH_QUERY(Query_for_partition_of_table);
 	}
+	else if (Matches("ALTER", "TABLE", MatchAny, "DETACH", "PARTITION", MatchAny))
+		COMPLETE_WITH("CONCURRENTLY", "FINALIZE");
 
 	/* ALTER TABLESPACE <foo> with RENAME TO, OWNER TO, SET, RESET */
 	else if (Matches("ALTER", "TABLESPACE", MatchAny))
-- 
2.20.1

Reply via email to