On Mon, Apr 19, 2021 at 4:28 PM vignesh C <vignes...@gmail.com> wrote: > > I have made the changes to update the replication statistics at > replication slot release. Please find the patch attached for the same. > Thoughts? >
Thanks, the changes look mostly good to me. The slot stats need to be initialized in RestoreSlotFromDisk and ReplicationSlotCreate, not in StartupDecodingContext. Apart from that, I have moved the declaration of UpdateDecodingStats from slot.h back to logical.h. I have also added/edited a few comments. Please check and let me know what do you think of the attached? -- With Regards, Amit Kapila.
v2-0001-Update-decoding-stats-during-replication-slot-rel.patch
Description: Binary data
