On Thu, May 6, 2021 at 1:09 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, May 6, 2021 at 6:15 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > After more thought, I'm concerned that my patch's approach might be > > invasive for PG14. Given that Vignesh’s patch would cover most cases, > > > > I am not sure if your patch is too invasive but OTOH I am also > convinced that Vignesh's patch covers most cases and is much simpler > so we can go ahead with that.
I think that my patch affects also other codes including logical decoding and decoding context. We will need to write code while worrying about MyLogicalDecodingContext. > In the attached, I have combined > Vignesh's patch and your doc fix patch. Additionally, I have changed > some comments and some other cosmetic stuff. Let me know what you > think of the attached? Thank you for updating the patch. The patch looks good to me. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
