On Tue, May 18, 2021 at 1:43 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > > The fix looks fine but I think along with this we should also return > > immediately from the pause loop if promotion is requested. Because if > > we recheck the recovery pause then someone can pause again and we will > > be in loop so better to exit as soon as promotion is requested, see > > attached patch. Should be applied along with your patch. > > But this change can cause the recovery to continue with insufficient parameter > settings if a promotion is requested while the server is in the paused state > because of such invalid settings. This behavior seems not safe. > If this my understanding is right, the recovery should abort immediately > (i.e., FATAL error ""recovery aborted because of insufficient parameter > settings" > should be thrown) if a promotion is requested in that case, like when > pg_wal_replay_resume() is executed in that case. Thought?
Yeah, you are right, I missed that. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
