On Wed, May 26, 2021 at 7:44 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Wed, May 26, 2021 at 7:18 PM vignesh C <vignes...@gmail.com> wrote: > > +1 for fixing this issue, we have handled this error in other places. > > The patch does not apply on head, could you rebase the patch on head > > and post a new patch. > > Thanks. I thought of rebasing once the other patch (which reorganizes > "...specified more than once" error) gets committed. Anyways, I've > rebased for now on the latest master. Please review v2 patch. >
Thanks for the updated patch. One minor comment: You can remove the brackets around errcode, You could change: + if (localeEl) + ereport(ERROR, + (errcode(ERRCODE_SYNTAX_ERROR), + errmsg("option \"%s\" specified more than once", defel->defname), + parser_errposition(pstate, defel->location))); to: + if (localeEl) + ereport(ERROR, + errcode(ERRCODE_SYNTAX_ERROR), + errmsg("option \"%s\" specified more than once", defel->defname), + parser_errposition(pstate, defel->location)); Regards, Vignesh